chore(kno-10998): Updating managing members page #1246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
scoti-knock
commented
Jan 5, 2026
scoti-knock
commented
Jan 5, 2026
| ### Removing members | ||
|
|
||
| Members can be removed from an account from the three dot menu. Removing a member will revoke their access to Knock and immediately invalidate any session associated with the user. Additionally, the member will also be sent an email letting them know that they have been removed from the account. | ||
| Members with appropriate [permissions](/manage-your-account/roles-and-permissions) can remove other members from an account by clicking the "Remove member" option found in the three-dot menu. Removing a member will revoke their access to Knock and immediately invalidate any session associated with the member. The removed member will receive an email informing them of the change in account access. |
Contributor
Author
There was a problem hiding this comment.
Note from PR summary: I've intentionally referred to permissions broadly ("with appropriate permissions") rather than using role names. I did this in hopes that this page doesn't become outdated when the RBAC project is released.
cellomatt
approved these changes
Jan 5, 2026
Comment on lines
103
to
105
| Users can't change their own roles or remove themselves from a Knock | ||
| account and accounts must have at least one <code>owner</code> at all | ||
| times. |
Contributor
There was a problem hiding this comment.
Suggested change
| Users can't change their own roles or remove themselves from a Knock | |
| account and accounts must have at least one <code>owner</code> at all | |
| times. | |
| Users can't change their own roles or remove themselves from a Knock | |
| account, and accounts must have at least one <code>owner</code> at all | |
| times. |
There's something that reads funny about this that I can't quite put my finger on; I think it's the "or" followed by the "and". Alternatively:
Suggested change
| Users can't change their own roles or remove themselves from a Knock | |
| account and accounts must have at least one <code>owner</code> at all | |
| times. | |
| Users can't change their own roles or remove themselves from a Knock | |
| account. Accounts must have at least one <code>owner</code> at all | |
| times. |
Contributor
Author
There was a problem hiding this comment.
Yeah I was back and forth on this too — I'll push an update
Co-authored-by: Matt Kufchak <matt@knock.app>
Co-authored-by: Matt Kufchak <matt@knock.app>
Co-authored-by: Matt Kufchak <matt@knock.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to managing account members documentation
Updates managing members docs for improved clarity and style guide alignment.
Changes:
Adding members→Inviting members,Managing invitations,Enabling auto-join) and shortened header names to create a clean (not wrapping) TOC.Note: I've intentionally referred to permissions broadly ("with appropriate permissions") rather than using role names. I did this in hopes that this page doesn't become outdated when the RBAC project is released.