Skip to content

Conversation

@knightedcodemonkey
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings January 4, 2026 01:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a dual package hazard allowlist feature, allowing developers to suppress warnings for specific packages when using the --detect-dual-package-hazard flag. The implementation includes CLI option parsing, filtering logic, integration with the transform and rewrite pipelines, and comprehensive test coverage.

  • Introduces --dual-package-hazard-allowlist CLI flag accepting comma-separated package names
  • Implements filterDualPackageDiagnostics utility function to filter out allowlisted packages from dual-package hazard diagnostics
  • Updates dependency from @knighted/module RC version to stable release
  • Removes test step from publish workflow

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/util.js Adds filterDualPackageDiagnostics and hazardPackageFromMessage helper functions for filtering diagnostics based on package allowlist
src/init.js Adds CLI option definition, parsing, and validation for the allowlist parameter
src/duel.js Integrates allowlist filtering throughout transform and rewrite pipelines; applies filtering to project-scope and file-scope diagnostics
src/resolver.js Passes dual package hazard configuration options (including allowlist) to the rewrite pipeline
test/unit.js Adds unit test verifying filterDualPackageDiagnostics correctly filters diagnostics by allowlist
test/integration.js Adds integration tests verifying hazard warnings are emitted or suppressed based on allowlist configuration
README.md Documents new --dual-package-hazard-allowlist CLI option and clarifies mode behavior
docs/v4-migration.md Adds migration note about default copy strategy and updates reference config boundary description
package.json Bumps version to 4.0.0-rc.6 and updates @knighted/module dependency to stable 1.5.0
package-lock.json Updates lockfile with new dependency versions
.github/workflows/publish.yml Removes test step from publish workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 4, 2026

Codecov Report

❌ Patch coverage is 87.07483% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.02%. Comparing base (ea90e58) to head (faf5b0a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/duel.js 84.52% 13 Missing ⚠️
src/init.js 79.31% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   93.48%   93.02%   -0.46%     
==========================================
  Files           4        4              
  Lines        2071     2208     +137     
==========================================
+ Hits         1936     2054     +118     
- Misses        135      154      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knightedcodemonkey knightedcodemonkey merged commit 229b4ec into main Jan 4, 2026
6 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch January 4, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants