Skip to content

Conversation

@knightedcodemonkey
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings January 3, 2026 19:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances tsconfig extends support for monorepo setups by expanding the allowed workspace boundary beyond just the project root to include parent and grandparent directories. This enables packages in a monorepo to extend a shared base tsconfig located at the workspace root.

Key Changes:

  • Introduced workspace boundary concept with three allowed roots: package root, parent root, and workspace root
  • Replaced project root validation with workspace-relative path handling that supports multiple allowed roots
  • Updated error messages from "project root" to "allowed workspace boundary" for better clarity

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/duel.js Core implementation: removed normalize import, added allowedConfigRoots logic with helper functions (isInAllowedRoots, toWorkspaceRelative, requireWorkspaceRelative), updated path resolution throughout to use workspace-relative paths instead of project-relative paths
test/integration.js Added test fixture paths for monorepo-extends scenario, new test case validating monorepo tsconfig extends behavior, updated error message assertion
test/__fixtures__/monorepo-extends/tsconfig.base.json Base TypeScript configuration for monorepo fixture
test/__fixtures__/monorepo-extends/packages/a/tsconfig.json Package-level config extending the base config
test/__fixtures__/monorepo-extends/packages/a/src/index.ts Sample TypeScript source for testing
test/__fixtures__/monorepo-extends/packages/a/package.json Package manifest for monorepo test fixture

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 3, 2026

Codecov Report

❌ Patch coverage is 71.11111% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.48%. Comparing base (5832598) to head (d4b6603).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/duel.js 71.11% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   94.33%   93.48%   -0.86%     
==========================================
  Files           4        4              
  Lines        2031     2071      +40     
==========================================
+ Hits         1916     1936      +20     
- Misses        115      135      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knightedcodemonkey knightedcodemonkey merged commit ea90e58 into main Jan 3, 2026
6 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch January 3, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants