Skip to content

Conversation

@knightedcodemonkey
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings January 3, 2026 17:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables the ESLint no-use-before-define rule and fixes a violation by moving the hasReferences variable declaration before its usage. The version is also bumped to 4.0.0-rc.5.

  • Adds no-use-before-define ESLint rule to the configuration
  • Moves hasReferences declaration earlier in the code to be defined before the runBuild function that references it
  • Bumps package version to 4.0.0-rc.5

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
eslint.config.js Adds the no-use-before-define ESLint rule to enforce variable declaration before usage
src/duel.js Moves hasReferences variable declaration from line ~224 to lines 99-100, before its usage in the runBuild function
package.json Updates version from 4.0.0-rc.4 to 4.0.0-rc.5
package-lock.json Updates version references to match package.json

The changes look good! The code correctly addresses the no-use-before-define linting issue by moving the hasReferences variable declaration to before the runBuild function definition where it's used. The variable is now properly scoped and defined before its first usage, which aligns with best practices and the newly enabled ESLint rule.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.33%. Comparing base (8e15c0b) to head (80de34e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   94.34%   94.33%   -0.01%     
==========================================
  Files           4        4              
  Lines        2032     2031       -1     
==========================================
- Hits         1917     1916       -1     
  Misses        115      115              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knightedcodemonkey knightedcodemonkey merged commit 5832598 into main Jan 3, 2026
12 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch January 3, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants