Increase code coverage #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSTL
added
bug-fix
enhancement
ashokdey
requested changes
Oct 26, 2019
| @@ -0,0 +1,40 @@ | |||
| const DLL = require('.'); | |||
|
|
|||
There was a problem hiding this comment.
Check for DLL should be a Class
| expect(queue.dequeue()).toEqual(null); | ||
| }); | ||
|
|
||
| it('Length of linkedlist', () => { |
There was a problem hiding this comment.
'Length of linkedlist' should be 'Size of Queue'
| expect(queue2.length()).toEqual(4); | ||
| }); | ||
|
|
||
| it('Destroy linkedList', () => { |
There was a problem hiding this comment.
'Destroy linkedList' should be 'Destroy Queue'
| describe('Doubly Linked List', () => { | ||
| const doublyLinkedList = new DLL(); | ||
|
|
||
| it('create DLL', () => { |
There was a problem hiding this comment.
'create DLL' -> 'It should create a DLL'
It's all about Behavior Driven Testing, hence it starts with or contains should
| expect(doublyLinkedList.length()).toEqual(0); | ||
| }); | ||
|
|
||
| it('addAtBeginning', () => { |
| @@ -3,18 +3,15 @@ | |||
| * | |||
| * Given values of two values n1 and n2 in a Binary Search Tree, find the Lowest Common Ancestor (LCA). You may assume that both the values exist in the tree. | |||
| */ | |||
|
|
|||
There was a problem hiding this comment.
Write a meaningful function name
| function lca(node, n1, n2) { | ||
| if (node == null) | ||
| return null; | ||
| if (node == null) return null; |
| @@ -5,8 +5,7 @@ const BinarySearchTree = require('../index'); | |||
| // {"left":{"left":{"data":4},"right":{"left":{"data":10},"right":{"data":14},"data":12},"data":8},"right":{"data":22},"data":20} | |||
|
|
|||
| describe('LCA', () => { | |||
|
|
|||
| let bst = new BinarySearchTree(20); | |||
| const bst = new BinarySearchTree(20); | |||
Comment on lines
6
to
11
| bst.add(4); | ||
| bst.add(9); | ||
| bst.add(2); | ||
| bst.add(5); | ||
| bst.add(8); | ||
| bst.add(12); |
Comment on lines
17
to
23
| bst.remove(6); | ||
| bst.remove(4); | ||
| bst.remove(9); | ||
| bst.remove(2); | ||
| bst.remove(5); | ||
| bst.remove(8); | ||
| bst.remove(12); |
|
Thanks @ashokdey . Please review the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 What's Inside?
- TernarySearch
- JumpSearch
- get-smallest-common-number
- anagrams
- AStar
- lowest-common-ancestor
- height-of-bst
- postfix-expression-evaluation
- Queue
- LinkedList
🎉 New Coverage will be 97% after merging.