Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

Support deep-linking to tabs #175

Open
evankanderson opened this issue May 21, 2020 · 5 comments
Open

Support deep-linking to tabs #175

evankanderson opened this issue May 21, 2020 · 5 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/good-first-issue Denotes an issue ready for a new contributor.

Comments

@evankanderson
Copy link
Member

From @mattmoor

One thing I do NOT like about the tabs is that I cannot deep-link an optional install guide
@evankanderson
Copy link
Member Author

/kind good-first-issue

@knative-prow-robot
Copy link
Contributor

@evankanderson: The label(s) kind/good-first-issue cannot be applied, because the repository doesn't have them

In response to this:

/kind good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@evankanderson
Copy link
Member Author

/kind good-first-issue
/good-first-issue

@knative-prow-robot
Copy link
Contributor

@evankanderson:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/kind good-first-issue
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added kind/good-first-issue Denotes an issue ready for a new contributor. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 18, 2020
@RichieEscarez
Copy link
Contributor

The tabs use Bootstrap (class=tab=pane). I think this feature would need custom javascript to be able toggle to the tab that you want: https://getbootstrap.com/docs/4.0/components/navs/#methods

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/good-first-issue Denotes an issue ready for a new contributor.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@evankanderson @RichieEscarez @knative-prow-robot