Skip to content

Bump Go 1.23 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2025
Merged

Bump Go 1.23 #39

merged 2 commits into from
Jun 12, 2025

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Mar 14, 2025

What this PR does, why we need it:

Bump Go 1.23

@knative-prow knative-prow bot requested review from mgencur and upodroid March 14, 2025 12:15
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2025
@cardil
Copy link
Contributor Author

cardil commented Mar 14, 2025

/kind cleanup

@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 14, 2025
@cardil cardil mentioned this pull request Mar 14, 2025
Closed
@cardil
Copy link
Contributor Author

cardil commented Mar 14, 2025

The failure is for Golang 1.24 only:

# knative.dev/toolbox/pkg/gcs/mock
# [knative.dev/toolbox/pkg/gcs/mock]
pkg/gcs/mock/mock_example_test.go:59:1: ExampleSetError refers to unknown identifier: SetError
ok  	knative.dev/toolbox/pkg/gcs	0.004s
FAIL	knative.dev/toolbox/pkg/gcs/mock [build failed]
FAIL

@cardil
Copy link
Contributor Author

cardil commented Mar 14, 2025

/assign @dsimansk
/cc @upodroid
/cc @dprotaso

@knative-prow knative-prow bot requested a review from dprotaso March 14, 2025 14:05
@dprotaso
Copy link
Member

dprotaso commented Jun 2, 2025

might want go1.24 now

@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jun 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit e9fe9e8 into knative:main Jun 12, 2025
22 checks passed
@dsimansk
Copy link
Contributor

I'd consider @dprotaso to bump to 1.24 as this is a bit old and stale at this point. :)

@cardil cardil deleted the chore/bump-golang branch June 13, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgencur mgencur Awaiting requested review from mgencur

@upodroid upodroid Awaiting requested review from upodroid

@dprotaso dprotaso Awaiting requested review from dprotaso

Assignees

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cardil @dprotaso @dsimansk