Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.15] Use a different 'static' image that supports s390x and ppc #15409

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #15407

Support s390x/ppc when building our controllers

@knative-prow knative-prow bot requested review from izabelacg and skonto July 25, 2024 05:40
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 25, 2024
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2024
Copy link

knative-prow bot commented Jul 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.58%. Comparing base (34cef98) to head (258c722).

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.15   #15409      +/-   ##
================================================
- Coverage         84.61%   84.58%   -0.03%     
================================================
  Files               219      219              
  Lines             13587    13587              
================================================
- Hits              11497    11493       -4     
- Misses             1724     1726       +2     
- Partials            366      368       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot merged commit 83d3e5e into knative:release-1.15 Jul 25, 2024
64 checks passed
openshift-merge-bot bot pushed a commit to openshift-knative/serving that referenced this pull request Aug 5, 2024
* Use a different 'static' image that supports s390x and ppc (knative#15409)

Updated image is recommended by Chainguard
Details here: https://www.chainguard.dev/unchained/changes-to-static-git-and-busybox-developer-images-2

Co-authored-by: dprotaso <dprotaso@gmail.com>

* clean up (knative#15418)

Co-authored-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>

* clean up old certificate leases (knative#15424)

Co-authored-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>

* [release-1.15] Fix bug in cert manager config (knative#15437)

* add test to cover cert manager config edge case

* fix edge case bug in cert manager config

---------

Co-authored-by: Marius Stein <mariusstein7@gmail.com>

---------

Co-authored-by: Knative Prow Robot <automation+prow-robot@knative.team>
Co-authored-by: dprotaso <dprotaso@gmail.com>
Co-authored-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>
Co-authored-by: Marius Stein <mariusstein7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants