Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the k8s service name from kubectl get revision output #15260

Merged
merged 1 commit into from
May 27, 2024

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented May 27, 2024

The K8s Service name has the same name as the revision. We dropped this field from the status so this column has always been showing an empty string.

Release Note

`kubectl get revision`  - no longer shows an empty column for `K8S Service Name`

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 27, 2024
@knative-prow knative-prow bot requested review from izabelacg and skonto May 27, 2024 18:07
Copy link

knative-prow bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
@dprotaso
Copy link
Member Author

/assign @izabelacg

@dprotaso
Copy link
Member Author

/cherry-pick release-1.14

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member Author

/cherry-pick release-1.13

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.75%. Comparing base (71d1654) to head (1263f18).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15260   +/-   ##
=======================================
  Coverage   84.74%   84.75%           
=======================================
  Files         218      218           
  Lines       13479    13479           
=======================================
+ Hits        11423    11424    +1     
  Misses       1688     1688           
+ Partials      368      367    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@izabelacg
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
@dprotaso
Copy link
Member Author

/override "certmanager-integration-tests_serving_main"

Copy link

knative-prow bot commented May 27, 2024

@dprotaso: Overrode contexts on behalf of dprotaso: certmanager-integration-tests_serving_main

In response to this:

/override "certmanager-integration-tests_serving_main"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit fc2ce76 into knative:main May 27, 2024
64 checks passed
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #15262

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #15263

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants