Revert Parallelise tests in activator/net #10904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to have introduced some flakiness. Ideally we'd fix those flakes and keep the parallelisation but I think it's going to be easier to fix the flakes after some tidying of this package, and in the meantime I don't want everyone to have to deal with flaky tests.
knative-prow-robot
added
size/M
Codecov Report
@@ Coverage Diff @@
## master #10904 +/- ##
==========================================
- Coverage 88.04% 88.02% -0.03%
==========================================
Files 188 188
Lines 9100 9100
==========================================
- Hits 8012 8010 -2
- Misses 833 835 +2
Partials 255 255
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to have introduced some flakiness. Ideally we'd fix those flakes and keep the parallelisation but I think it's going to be easier to fix the flakes after some tidying of this package (it's pretty overdue anyway 🤷), and in the meantime I don't want everyone to have to deal with flaky tests.
Fixes #10890.
/assign @markusthoemmes @vagababov