Skip to content

Conversation

@knative-automation
Copy link
Contributor

Produced via:

prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)

Cron. -knative-prow-robot
/cc knative/serving-writers
/assign knative/serving-writers

Signed-off-by: Knative Automation <automation@knative.team>
@knative-prow-robot knative-prow-robot requested a review from a team March 5, 2021 01:32
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 5, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 5, 2021
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #10898 (6f0a503) into master (5b07374) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10898      +/-   ##
==========================================
+ Coverage   88.02%   88.04%   +0.02%     
==========================================
  Files         188      188              
  Lines        9100     9100              
==========================================
+ Hits         8010     8012       +2     
+ Misses        834      833       -1     
+ Partials      256      255       -1     
Impacted Files Coverage Δ
pkg/reconciler/configuration/configuration.go 88.28% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6087145...2338f8e. Read the comment docs.

Copy link
Member

@dprotaso dprotaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2021
@knative-prow-robot knative-prow-robot merged commit 6e46a52 into knative:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants