Add DomainMapping namespace label annotation #10868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know how useful this is since the DM/route namespace and ingress NS are always the same, but adding this to be consistent with Route which adds a similar label.
knative-prow-robot
added
area/API
Codecov Report
@@ Coverage Diff @@
## master #10868 +/- ##
==========================================
- Coverage 88.12% 88.02% -0.10%
==========================================
Files 188 188
Lines 9041 9102 +61
==========================================
+ Hits 7967 8012 +45
- Misses 825 834 +9
- Partials 249 256 +7
Continue to review full report at Codecov.
|
knative-prow-robot
added
size/S
|
/lgtm |
|
still needs an approve from someone /assign @vagababov @dprotaso |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't honestly know how useful this is since the DM/route namespace and the Ingress
NS are always the same, but seems nice to add this to be consistent with Route
which adds a similar
RouteNamespaceLabelKeylabel when it appliesRouteLabelKey, since we added an equivalentDomainMappingLabelKeyin #10370./assign @markusthoemmes @nak3