Be consistent in reading revision headers #10563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context_handler uses the _first_ RevisonName/Namespace header, whereas request_log uses the _last_. In practice the Revision header is added by AppendHeaders which (confusingly) actually overwrites rather than appending, so there's only ever one value of the header so this doesn't make any difference -- but doing it the same way in both places is both (a) nicer / less confusing and (b) lets us drop our custom LastHeaderValue function in favour of using the standard golang net/http header.Get in both places.
knative-prow-robot
added
the
size/M
Codecov Report
@@ Coverage Diff @@
## master #10563 +/- ##
==========================================
- Coverage 88.07% 88.07% -0.01%
==========================================
Files 186 185 -1
Lines 8831 8827 -4
==========================================
- Hits 7778 7774 -4
Misses 811 811
Partials 242 242
Continue to review full report at Codecov.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContextHandler uses the first RevisonName/Namespace header, whereas RequestLog uses the last.
In practice the Revision headers are added by AppendHeaders which (confusingly) actually overwrites rather than appending, so there's only ever one value of the header so this doesn't make any difference -- but doing it the same way in both places is (a) nicer / less confusing and (b) lets us drop our custom LastHeaderValue function in favour of using the standard golang net/http header.Get in both places.
/assign @markusthoemmes @vagababov