Skip to content

Conversation

@vagababov
Copy link
Contributor

So 0.18, 0.19 and 0.20 have both labes, enough time now to deprecate the
old one.

/assign mattmoor @dprotaso @tcnghia

So 0.18, 0.19 and 0.20 have both labes, enough time now to deprecate the
old one.

Change-Id: I510ee88b97784b2d836b9caf5262d268568e7495
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 14, 2021
@vagababov
Copy link
Contributor Author

/assign @nak3

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 14, 2021
@knative-prow-robot knative-prow-robot added area/API API objects and controllers area/networking approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 14, 2021
Change-Id: If7e52ee61357c36470d8c36c6cb145448c07bad3
Copy link
Contributor

@tcnghia tcnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tcnghia, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #10559 (a261bd5) into master (89cbb09) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10559      +/-   ##
==========================================
- Coverage   88.04%   88.04%   -0.01%     
==========================================
  Files         186      186              
  Lines        8834     8831       -3     
==========================================
- Hits         7778     7775       -3     
  Misses        812      812              
  Partials      244      244              
Impacted Files Coverage Δ
pkg/apis/serving/v1/configuration_validation.go 100.00% <100.00%> (ø)
pkg/apis/serving/v1/route_validation.go 97.87% <100.00%> (ø)
pkg/apis/serving/v1/service_validation.go 100.00% <100.00%> (ø)
pkg/reconciler/route/config/domain.go 100.00% <100.00%> (ø)
pkg/reconciler/route/domains/domains.go 100.00% <100.00%> (ø)
pkg/reconciler/route/resources/filters.go 100.00% <100.00%> (ø)
pkg/reconciler/route/resources/labels/labels.go 100.00% <100.00%> (ø)
pkg/reconciler/route/resources/service.go 87.64% <100.00%> (ø)
pkg/autoscaler/statforwarder/forwarder.go 90.74% <0.00%> (-5.56%) ⬇️
pkg/autoscaler/statforwarder/processor.go 83.33% <0.00%> (-5.56%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89cbb09...08287b0. Read the comment docs.

@knative-prow-robot knative-prow-robot merged commit e402e8e into knative:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants