Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade test shell invoker logs isn't showing up in a subtest log output #14461

Closed
dprotaso opened this issue Sep 29, 2023 · 5 comments · Fixed by #14495 or knative/pkg#2856
Closed

upgrade test shell invoker logs isn't showing up in a subtest log output #14461

dprotaso opened this issue Sep 29, 2023 · 5 comments · Fixed by #14495 or knative/pkg#2856

Comments

@dprotaso
Copy link
Member

Noticed during some upgrade test runs that the subtests don't have verbose logs - so it's unclear what the failure is

Screenshot 2023-09-29 at 11 33 52 AM

Looking at the raw output will https://gist.github.com/dprotaso/514807299f699353acc8d4adf8144789 show you there are logs being printed to stdout/stderr directly

For the upgrade tests we should direct this output to the subtest it was invoked

@dprotaso
Copy link
Member Author

The default values should be overridden for upgrade tests

https://github.com/knative/hack/blob/f2f9b6f91263b25040acf4a98cafc9b6d7db0230/shell/executor.go#L81-L86

	if config.Out == nil {
		config.Out = os.Stdout
	}
	if config.Err == nil {
		config.Err = os.Stderr
	}

@cardil
Copy link

cardil commented Sep 29, 2023

I think I'll move this issue to the hack repo.

It looks I can't do it.

@cardil
Copy link

cardil commented Sep 29, 2023

/transfer hack

@cardil
Copy link

cardil commented Oct 12, 2023

/reopen

There are PRs needs to be done.

@knative-prow knative-prow bot reopened this Oct 12, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 12, 2023

@cardil: Reopened this issue.

In response to this:

/reopen

There are PRs needs to be done.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants