Skip to content

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Aug 4, 2025

No description provided.

@knative-prow
Copy link

knative-prow bot commented Aug 4, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2025
@knative-prow knative-prow bot requested review from creydr and mgencur August 4, 2025 21:11
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/test-and-release labels Aug 4, 2025
@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.05%. Comparing base (e06d4c9) to head (e949fd4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3227      +/-   ##
==========================================
+ Coverage   74.63%   75.05%   +0.42%     
==========================================
  Files         209      187      -22     
  Lines       12022    10240    -1782     
==========================================
- Hits         8973     7686    -1287     
+ Misses       2770     2314     -456     
+ Partials      279      240      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2025
@dprotaso dprotaso force-pushed the drop-opencensus-packages branch from cab00cf to db448e3 Compare August 4, 2025 21:25
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2025
@dprotaso dprotaso force-pushed the drop-opencensus-packages branch from 1aa7646 to 32ff17c Compare August 11, 2025 18:19
@dprotaso dprotaso marked this pull request as ready for review August 13, 2025 14:32
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2025
@knative-prow knative-prow bot requested a review from evankanderson August 13, 2025 14:32
@dprotaso
Copy link
Member Author

This is good to merge and I'd rather not block on the downstream test being red.

Summary:

  • operator - needs a deps bump and downstream will go green. Blocked on some eventing upgrade test
  • kafka-broker - tests are flakey - i tried to push some changes to unblock the dep updated but I don't know enough to fix it

/assign @Cali0707 @evankanderson

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@creydr @matzew let's keep an eye on the EKB/operator eventing bits to make sure we get everything green eventually

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2025
@knative-prow
Copy link

knative-prow bot commented Aug 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 6c39c7c into knative:main Aug 13, 2025
36 of 38 checks passed
@evankanderson
Copy link
Member

/lgtm

We're at a good point in the release cycle to have time to fix breakages.

I hope this doesn't have impacts on outside-Knative consumers of pkg.

@dprotaso dprotaso deleted the drop-opencensus-packages branch August 13, 2025 18:18
@dprotaso
Copy link
Member Author

I hope this doesn't have impacts on outside-Knative consumers of pkg.

I reached out to Tekton and they were happy about our OTel support. They actually added OTel tracing downstream vs trying to upstream it into knative.dev/pkg.

I gave some notice to sigstore but no one replied to my messages so unsure if they cared.

Either way the alternative is there so the migration can happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants