-
Notifications
You must be signed in to change notification settings - Fork 338
drop opencensus packages #3227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop opencensus packages #3227
Conversation
|
Skipping CI for Draft Pull Request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3227 +/- ##
==========================================
+ Coverage 74.63% 75.05% +0.42%
==========================================
Files 209 187 -22
Lines 12022 10240 -1782
==========================================
- Hits 8973 7686 -1287
+ Misses 2770 2314 -456
+ Partials 279 240 -39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cab00cf to
db448e3
Compare
1aa7646 to
32ff17c
Compare
|
This is good to merge and I'd rather not block on the downstream test being red. Summary:
/assign @Cali0707 @evankanderson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm We're at a good point in the release cycle to have time to fix breakages. I hope this doesn't have impacts on outside-Knative consumers of |
I reached out to Tekton and they were happy about our OTel support. They actually added OTel tracing downstream vs trying to upstream it into knative.dev/pkg. I gave some notice to sigstore but no one replied to my messages so unsure if they cared. Either way the alternative is there so the migration can happen |
No description provided.