Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate knative.dev/hack/shell to knative.dev/pkg/test/shell #2856

Merged
merged 12 commits into from
Oct 12, 2023
Merged

Migrate knative.dev/hack/shell to knative.dev/pkg/test/shell #2856

merged 12 commits into from
Oct 12, 2023

Commits on Oct 10, 2023

  1. Move shell package from knative.dev/hack under test/shell

    @mgencur
    mgencur committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    88698c0 View commit details
    Browse the repository at this point in the history

  2. Provide Streams for shell executor that writes to t.Log

    @mgencur
    mgencur committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    974d18b View commit details
    Browse the repository at this point in the history

  3. Remove temporary comment

    @mgencur
    mgencur committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    3cfcbc6 View commit details
    Browse the repository at this point in the history

  4. Fix style

    @mgencur
    mgencur committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    f6e0044 View commit details
    Browse the repository at this point in the history

  5. Fix lint

    @mgencur
    mgencur committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    25f0adf View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Do not fail when writing to stderr 

    * use own interface TestingT
    @mgencur
    mgencur committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    64dda1e View commit details
    Browse the repository at this point in the history

  2. Fix arguments for Logf

    @mgencur
    mgencur committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    551d95b View commit details
    Browse the repository at this point in the history

  3. Fix comments

    @mgencur
    mgencur committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    7e238a1 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. NewExecutor function requires TestingT and ProjectLocation

    @mgencur
    mgencur committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    ae89365 View commit details
    Browse the repository at this point in the history

  2. Move pkg/test/shell under pkg/test/upgrade/shell

    @mgencur
    mgencur committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b0c1be6 View commit details
    Browse the repository at this point in the history

  3. ProjectLocation is always passed 

    It is now a required argument for NewExecutor function
    @mgencur
    mgencur committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    3abb743 View commit details
    Browse the repository at this point in the history

  4. Remove redundant file

    @mgencur
    mgencur committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    270ad20 View commit details
    Browse the repository at this point in the history