[WIP] Use Update to set finalizers in reconciler #2838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using patch to set finalizers might lead to having reconciled resources that are never finalized since `PATCH` doesn't have any optimistic concurrency controls [1]. [1] https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/ Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
knative-prow
bot
added
kind/bug
pierDipi
changed the title
knative-prow
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2838 +/- ##
==========================================
- Coverage 81.86% 81.82% -0.04%
==========================================
Files 167 167
Lines 10224 10224
==========================================
- Hits 8370 8366 -4
- Misses 1608 1612 +4
Partials 246 246 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
emit-update-to-set-finalizers
branch
from
4f759f3
to
a9424f0
Compare
|
@pierDipi I'm curious, why does Update prevent the race condition caused by Patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using patch to set finalizers might lead to having reconciled
resources that are never finalized since
PATCHdoesn't haveany optimistic concurrency controls [1] so we might reconciling
a resource that has been deleted after being fetched from the
API Server.
[1] https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/
Changes
/kind bug
Fixes #2828
Release Note
Docs