Skip to content

Feature: Add --platform flag for CI/CD platform selection. #3379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 2 commits into from
Jan 21, 2026
Merged

Feature: Add --platform flag for CI/CD platform selection. #3379

knative-prow merged 2 commits into from
Jan 21, 2026

Conversation

@twoGiants
Copy link
Contributor

@twoGiants twoGiants commented Jan 21, 2026

Changes

  • 🎁 Add --platform flag to config ci command for CI/CD platform selection
  • 🎁 Default platform to "github" with case-insensitive matching
  • 🎁 Return descriptive error for unsupported platforms, preparing for future platform additions

/kind enhancement

Relates to #3256

Release Note

Add --platform flag to `func config ci` command allowing users to specify which CI/CD platform to generate manifests for. Currently supports "github" (default).

Docs

@twoGiants
feat: add --platform flag for CI/CD platform selection
a844153 
Add a new --platform flag to the config ci command that allows users to
specify which CI/CD platform to generate manifests for. The flag
defaults to "github" and is case-insensitive.

Currently only GitHub is supported. Using any other value returns
a descriptive error message indicating the platform is not yet
implemented, preparing the codebase for future platform additions.

Issue knative#3256

Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 21, 2026
@twoGiants
Copy link
Contributor Author

twoGiants commented Jan 21, 2026

/cc @creydr @matejvasek @lkingland Thank you 😸 👍

@codecov
Copy link

codecov bot commented Jan 21, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.48%. Comparing base (66d2f4c) to head (dc5c4a7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3379      +/-   ##
==========================================
- Coverage   55.57%   55.48%   -0.10%     
==========================================
  Files         173      173              
  Lines       20061    20072      +11     
==========================================
- Hits        11148    11136      -12     
- Misses       7795     7821      +26     
+ Partials     1118     1115       -3
Flag Coverage Δ
e2e 39.68% <0.00%> (-0.03%) ⬇️
e2e go 35.47% <0.00%> (-0.03%) ⬇️
e2e node 31.26% <0.00%> (-0.01%) ⬇️
e2e python 34.97% <0.00%> (-0.03%) ⬇️
e2e quarkus 31.37% <0.00%> (-0.05%) ⬇️
e2e rust 30.81% <0.00%> (-0.02%) ⬇️
e2e springboot 29.27% <0.00%> (-0.02%) ⬇️
e2e typescript 31.34% <0.00%> (-0.04%) ⬇️
integration 18.58% <0.00%> (-0.02%) ⬇️
unit macos-14 44.75% <100.00%> (-0.13%) ⬇️
unit macos-latest 44.75% <100.00%> (-0.13%) ⬇️
unit ubuntu-24.04-arm 44.88% <100.00%> (-0.09%) ⬇️
unit ubuntu-latest 45.65% <100.00%> (-0.13%) ⬇️
unit windows-latest 44.78% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@creydr
Copy link
Member

creydr commented Jan 21, 2026

So IIUC correctly this is at the moment (without having other platforms supported) mostly to make the users aware, that only GH is supported at the moment. Correct?

gauron99
gauron99 reviewed Jan 21, 2026
View reviewed changes
cmd/ci/config.go Outdated

PathFlag = "path"

CICDPlatformFlag = "platform"
Copy link
Contributor

@gauron99 gauron99 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be just PlatformFlag ? do we expect another platform to be included in func config ci subcommand?

Copy link
Contributor Author

@twoGiants twoGiants Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gauron99 sure! I'll update it. Yes, gitlab will also come, maybe Tekton PAC too and others.

@creydr Because github is the default anyway, they don't even have to select it. Just in case they try they will see the only one supported for now is Github.

Copy link
Contributor

@gauron99 gauron99 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes great. I meant "different platform" as to that new thing would conflict with the naming so that we have to specify the CICD as well. Thanks for simplicifation

@twoGiants
refactor: pr review re-work
dc5c4a7 
This commit will be squashed.

Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@twoGiants twoGiants mentioned this pull request Jan 21, 2026
Open
gauron99
gauron99 approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2026
@knative-prow
Copy link

knative-prow bot commented Jan 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, twoGiants

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2026
@knative-prow knative-prow bot merged commit f473344 into knative:main Jan 21, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gauron99 gauron99 gauron99 approved these changes

@dsimansk dsimansk Awaiting requested review from dsimansk

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

Assignees

@gauron99 gauron99

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@twoGiants @creydr @gauron99