[DNM][WIP] Update templates (instanced signature) #3378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
approved
gauron99
force-pushed
the
instanced-funcs
branch
from
7487bf7 to
b7f9697
Compare
gauron99
changed the title
gauron99
changed the title
gauron99
force-pushed
the
instanced-funcs
branch
2 times, most recently
from
f9d335e to
73387d9
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3378 +/- ##
=======================================
Coverage 54.60% 54.61%
=======================================
Files 173 173
Lines 19807 19814 +7
=======================================
+ Hits 10816 10821 +5
- Misses 7860 7861 +1
- Partials 1131 1132 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gauron99
force-pushed
the
instanced-funcs
branch
4 times, most recently
from
3fbf389 to
4556925
Compare
knative-prow
bot
added
size/XL
gauron99
changed the title
gauron99
force-pushed
the
instanced-funcs
branch
from
4556925 to
9e11fe4
Compare
knative-prow
bot
added
size/L
Contributor
Author
|
/test all |
gauron99
force-pushed
the
instanced-funcs
branch
2 times, most recently
from
b3a6a98 to
9e8a5aa
Compare
knative-prow
bot
added
size/XL
gauron99
force-pushed
the
instanced-funcs
branch
from
9e8a5aa to
314e76e
Compare
knative-prow
bot
removed
the
size/XL
knative-prow
bot
added
the
size/L
gauron99
force-pushed
the
instanced-funcs
branch
from
314e76e to
7a776ad
Compare
knative-prow
bot
added
size/XL
gauron99
force-pushed
the
instanced-funcs
branch
4 times, most recently
from
d842983 to
e81e584
Compare
knative-prow-robot
added
the
needs-rebase
gauron99
force-pushed
the
instanced-funcs
branch
from
e81e584 to
2e63f49
Compare
knative-prow-robot
removed
the
needs-rebase
gauron99
force-pushed
the
instanced-funcs
branch
5 times, most recently
from
389f658 to
d85507b
Compare
knative-prow
bot
added
size/XXL
gauron99
force-pushed
the
instanced-funcs
branch
2 times, most recently
from
9f35948 to
62cc5e5
Compare
gauron99
force-pushed
the
instanced-funcs
branch
from
62cc5e5 to
53c2160
Compare
matejvasek
reviewed
Jan 29, 2026
| }) | ||
| await send({ | ||
| 'type': 'http.response.body', | ||
| 'body': url.encode(), |
Contributor
There was a problem hiding this comment.
Does encode make sense with a string that is not an url?
Contributor
There was a problem hiding this comment.
Maybe it does I don't know.
Contributor
Author
There was a problem hiding this comment.
This is string -> bytes conversion. thats whats required in the struct. I think this is equivalent to b"OK". You can specify what encoding you want "utf-8" "ascii" but we just use basic (no argument) which is utf-8
matejvasek
reviewed
Jan 29, 2026
| _ = fromCleanEnv(t, name) | ||
|
|
||
| if err := newCmd(t, "init", "-l=go").Run(); err != nil { | ||
| if err := newCmd(t, "init", "-l=go", |
Contributor
There was a problem hiding this comment.
Why now there is a git repo?
Contributor
There was a problem hiding this comment.
Ah that's a repo for templates, not func src code?
Contributor
Author
There was a problem hiding this comment.
yes im keeping the "echo" functionality and using the template to do it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http templates now return: "OK" string
cloudevents templates now return: json {"message":"OK"}