Skip to content

Conversation

@twoGiants
Copy link
Contributor

@twoGiants twoGiants commented Nov 29, 2025

Changes

  • 🧹 Fix typos in comments and documentation across the codebase

/kind cleanup

Related to #3256.

Release Note

NONE

Docs

NONE

@knative-prow knative-prow bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 29, 2025
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 29, 2025
@twoGiants
Copy link
Contributor Author

/test unit-tests

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2025
@twoGiants twoGiants force-pushed the issue-744-fix-typos branch from 0b73bed to a2c8b23 Compare December 1, 2025 08:50
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2025
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.51%. Comparing base (78f6d41) to head (d4ccf48).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/mcp.go 0.00% 1 Missing ⚠️
pkg/testing/testing.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3257      +/-   ##
==========================================
- Coverage   54.52%   54.51%   -0.02%     
==========================================
  Files         162      162              
  Lines       19216    19216              
==========================================
- Hits        10478    10475       -3     
- Misses       7694     7696       +2     
- Partials     1044     1045       +1     
Flag Coverage Δ
e2e 39.68% <50.00%> (ø)
e2e go 35.61% <50.00%> (ø)
e2e node 30.98% <50.00%> (ø)
e2e python 35.25% <50.00%> (ø)
e2e quarkus 31.14% <50.00%> (ø)
e2e rust 30.58% <50.00%> (ø)
e2e springboot 30.61% <50.00%> (ø)
e2e typescript 31.10% <50.00%> (ø)
integration 17.90% <0.00%> (ø)
unit macos-14 44.33% <50.00%> (ø)
unit macos-latest 44.33% <50.00%> (ø)
unit ubuntu-24.04-arm 44.53% <80.00%> (ø)
unit ubuntu-latest 45.26% <50.00%> (ø)
unit windows-latest 44.35% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The schema needed an update because a typo fix affects it. The same for
the generated filesystem.

Issue knative#3256

Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@twoGiants twoGiants force-pushed the issue-744-fix-typos branch from e1a6cf6 to d4ccf48 Compare December 1, 2025 10:51
@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2025
@gauron99
Copy link
Contributor

gauron99 commented Dec 1, 2025

/approve

@knative-prow
Copy link

knative-prow bot commented Dec 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, twoGiants

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2025
@knative-prow knative-prow bot merged commit 7f7e476 into knative:main Dec 1, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants