Replace sleep with proper readiness check in TestInt_DialInClusterService

[intojhanurag]

Fixed: #3211

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: intojhanurag
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow]

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.55%. Comparing base (fc761ce) to head (67adaf1).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3238      +/-   ##
==========================================
+ Coverage   51.80%   54.55%   +2.74%     
==========================================
  Files         162      162              
  Lines       19132    19132              
==========================================
+ Hits         9912    10438     +526     
+ Misses       8242     7655     -587     
- Partials      978     1039      +61     

Flag	Coverage Δ
e2e	39.71% <ø> (?)
e2e go	35.69% <ø> (?)
e2e node	31.02% <ø> (?)
e2e python	35.44% <ø> (?)
e2e quarkus	31.16% <ø> (?)
e2e rust	30.63% <ø> (?)
e2e springboot	30.67% <ø> (?)
e2e typescript	31.14% <ø> (?)
integration	17.88% <ø> (+<0.01%)	⬆️
unit macos-14	44.38% <ø> (ø)
unit macos-latest	44.38% <ø> (ø)
unit ubuntu-24.04-arm	44.57% <ø> (ø)
unit ubuntu-latest	45.32% <ø> (ø)
unit windows-latest	44.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[intojhanurag]

Hey @lkingland , It is ready now . Can you review it , if you have a moment.

[creydr]

Thanks for checking on this @intojhanurag

I left a comment.

[creydr]

We have a similar function already existing for this:

func/pkg/k8s/wait.go

Lines 21 to 30 in 84c2270

	func WaitForDeploymentAvailable(ctx context.Context, clientset *kubernetes.Clientset, namespace, deploymentName string, timeout time.Duration) error {
	return wait.PollUntilContextTimeout(ctx, 1*time.Second, timeout, true, func(ctx context.Context) (bool, error) {
	deployment, err := clientset.AppsV1().Deployments(namespace).Get(ctx, deploymentName, metav1.GetOptions{})
	if err != nil {
	return false, err
	}
	return checkIfDeploymentIsAvailable(ctx, clientset, deployment)
	})
	}

[intojhanurag]

Hey @creydr , Can you rerun the test ? I think this is a flake.

[creydr]

/ok-to-test
/retest