Skip to content

Conversation

@gauron99
Copy link
Contributor

No description provided.

@knative-prow
Copy link

knative-prow bot commented Nov 22, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 22, 2025
@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

❌ Patch coverage is 69.04762% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.61%. Comparing base (fc761ce) to head (cc15a7d).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/builders/buildpacks/builder.go 61.76% 10 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3237      +/-   ##
==========================================
+ Coverage   51.80%   54.61%   +2.80%     
==========================================
  Files         162      162              
  Lines       19132    19172      +40     
==========================================
+ Hits         9912    10470     +558     
+ Misses       8242     7662     -580     
- Partials      978     1040      +62     
Flag Coverage Δ
e2e 39.75% <68.00%> (?)
e2e go 35.73% <68.00%> (?)
e2e node 31.00% <28.00%> (?)
e2e python 35.41% <20.00%> (?)
e2e quarkus 31.16% <28.00%> (?)
e2e rust 30.63% <28.00%> (?)
e2e springboot 30.63% <28.00%> (?)
e2e typescript 31.12% <28.00%> (?)
integration 17.89% <16.00%> (+0.01%) ⬆️
unit macos-14 44.36% <40.00%> (-0.02%) ⬇️
unit macos-latest 44.36% <40.00%> (-0.02%) ⬇️
unit ubuntu-24.04-arm 44.57% <47.61%> (+<0.01%) ⬆️
unit ubuntu-latest 45.30% <40.00%> (-0.02%) ⬇️
unit windows-latest 44.39% <40.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99 gauron99 force-pushed the push-ywknoytomzzx branch 2 times, most recently from 73ce011 to f310b09 Compare November 22, 2025 15:36
@gauron99 gauron99 changed the title duplicated [DNM][WIP] duplicated func-util test Nov 22, 2025
@gauron99 gauron99 force-pushed the push-ywknoytomzzx branch 4 times, most recently from 5295030 to 8161b74 Compare November 24, 2025 07:04
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 24, 2025
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant