Skip to content

Conversation

@intojhanurag
Copy link
Contributor

fix: #3202

@knative-prow
Copy link

knative-prow bot commented Nov 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: intojhanurag
Once this PR has been reviewed and has the lgtm label, please assign lkingland for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 22, 2025

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.74%. Comparing base (fc761ce) to head (3a887ef).

❗ There is a different number of reports uploaded between BASE (fc761ce) and HEAD (3a887ef). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (fc761ce) HEAD (3a887ef)
integration 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3224      +/-   ##
==========================================
- Coverage   51.80%   44.74%   -7.07%     
==========================================
  Files         162      162              
  Lines       19132    19132              
==========================================
- Hits         9912     8560    -1352     
- Misses       8242     9821    +1579     
+ Partials      978      751     -227     
Flag Coverage Δ
integration ?
unit macos-14 44.38% <ø> (ø)
unit macos-latest 44.38% <ø> (ø)
unit ubuntu-24.04-arm 44.57% <ø> (ø)
unit ubuntu-latest 45.32% <ø> (ø)
unit windows-latest 44.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@intojhanurag
Copy link
Contributor Author

Hey @gauron99 , Can you give me suggestion to figure out that what i am missing actually my laptop is not able to handle the cluster , So I have not test locally till now .

@gauron99
Copy link
Contributor

Looking at the failed runs it simply shows that, for example, the flag -v is unknown Error: unknown shorthand flag: 'v' in -v

@gauron99
Copy link
Contributor

gauron99 commented Nov 24, 2025

You should be able to simply open each action and see what has failed (clicking on the "checks" below)

@gauron99
Copy link
Contributor

integration test TestInt_DialInClusterService shows

dialer_int_test.go:184: Get "http://helloworld-ggnc6.default.svc/": failed to exec in pod: command terminated with exit code 1 (stderr: "opening connection\nError: dial tcp :0->10.96.84.46:80: connect: connection refused\nUsage:\n  socat [-u] <address> <address> [flags]\n\nFlags:\n  -d, --debug string   log level (this flag is present only for compatibility and has no effect)\n  -h, --help           help for socat\n  -u, --unidirect      unidirectional mode (left to right)\n\nERROR: dial tcp :0->10.96.84.46:80: connect: connection refused\n")

@intojhanurag
Copy link
Contributor Author

@gauron99 , Thanks ! make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E2E Subscription Tests

2 participants