Skip to content

Conversation

@intojhanurag
Copy link
Contributor

Converts TestResource_Languages and TestResource_Templates into a single table-driven test to remove duplication and keep tests consistent.

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 14, 2025

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.82%. Comparing base (b039190) to head (802152a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3188      +/-   ##
==========================================
+ Coverage   51.81%   51.82%   +0.01%     
==========================================
  Files         162      162              
  Lines       19131    19131              
==========================================
+ Hits         9912     9914       +2     
+ Misses       8241     8240       -1     
+ Partials      978      977       -1     
Flag Coverage Δ
integration 17.88% <ø> (ø)
unit macos-14 44.37% <ø> (ø)
unit macos-latest 44.37% <ø> (ø)
unit ubuntu-24.04-arm 44.56% <ø> (ø)
unit ubuntu-latest 45.30% <ø> (-0.01%) ⬇️
unit windows-latest 44.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: intojhanurag, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2025
@lkingland
Copy link
Member

/retest

@intojhanurag
Copy link
Contributor Author

Hey @lkingland , If any issue is on my side. lmk I will be happy to improve.

@lkingland lkingland added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 21, 2025
@lkingland
Copy link
Member

lkingland commented Nov 21, 2025

/retest
If this rerun of the tests fails again, maybe rebase on main to get the new test suite.

@intojhanurag intojhanurag force-pushed the test/table-driven-resources branch from 2144a57 to 802152a Compare November 21, 2025 08:16
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 21, 2025

New changes are detected. LGTM label has been removed.

@intojhanurag
Copy link
Contributor Author

Hey @lkingland , I think this is a flake . what do you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants