Skip to content

Conversation

@knative-automation
Copy link
Contributor

@knative-automation knative-automation commented Apr 22, 2025

Cron -knative-prow-robot

/cc knative/func-approvers
/assign knative/func-approvers

Produced by: knative-extensions/knobots/actions/update-deps

@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch from 3354420 to 88a1043 Compare April 22, 2025 13:21
@knative-prow
Copy link

knative-prow bot commented Apr 22, 2025

@knative-automation: GitHub didn't allow me to request PR reviews from the following users: knative/func-approvers.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Cron -knative-prow-robot

/cc knative/func-approvers
/assign knative/func-approvers

Produced by: knative-extensions/knobots/actions/update-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 22, 2025
@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.44%. Comparing base (3d4d7da) to head (557dc8e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2800      +/-   ##
==========================================
+ Coverage   61.59%   62.44%   +0.84%     
==========================================
  Files         131      131              
  Lines       15794    15794              
==========================================
+ Hits         9728     9862     +134     
+ Misses       5155     4993     -162     
- Partials      911      939      +28     
Flag Coverage Δ
e2e-test 35.40% <ø> (ø)
e2e-test-oncluster 33.79% <ø> (+1.45%) ⬆️
e2e-test-oncluster-runtime 28.16% <ø> (?)
e2e-test-runtime-go 25.73% <ø> (?)
e2e-test-runtime-node 25.09% <ø> (?)
e2e-test-runtime-quarkus 25.17% <ø> (?)
e2e-test-runtime-rust 24.65% <ø> (?)
e2e-test-runtime-springboot 24.72% <ø> (?)
e2e-test-runtime-typescript 25.17% <ø> (?)
integration-tests 48.60% <ø> (+1.81%) ⬆️
unit-tests 48.66% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch from 88a1043 to 5a098a9 Compare April 23, 2025 01:42
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 23, 2025
@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch from 5a098a9 to 663d810 Compare April 23, 2025 15:04
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2025
@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch from 663d810 to a9a2f69 Compare April 24, 2025 01:41
@gauron99
Copy link
Contributor

tests are failing because of some formatting stuff. Ill take a look at this

@dsimansk
Copy link
Contributor

tests are failing because of some formatting stuff. Ill take a look at this

Yep, it's go 1.24 speciality. There's a change in compiler reporting Errorf usage. That should be now something like:

old

    return fmt.Errorf("unable retrieve user home dir to verify default container authentication. " + err.Error())

new

    return fmt.Errorf("unable retrieve user home dir to verify default container authentication. %s", err.Error())

@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch from a9a2f69 to c800da2 Compare April 24, 2025 11:11
@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch from c800da2 to 342f8ed Compare April 24, 2025 12:28
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
@gauron99
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
bumping knative.dev/serving 7f044f1...a4c4491:
  > a4c4491 update min go version to 1.24 (# 15856)
  > e74fe1a drop code clearing out the user agent (# 15857)
  > 128550c bump latest contour and istio (# 15858)
bumping knative.dev/eventing a7b2f1c...b99e57b:
  > b99e57b [main] Upgrade to latest dependencies (# 8567)
bumping knative.dev/client/pkg 6c6ddcd...96721e5:
  > 96721e5 [main] Upgrade to latest dependencies (# 1997)

Signed-off-by: Knative Automation <automation@knative.team>
@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch from 342f8ed to 557dc8e Compare April 24, 2025 13:22
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
@knative-prow
Copy link

knative-prow bot commented Apr 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, gauron99, knative-automation, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dsimansk,gauron99,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 4e9fc09 into knative:main Apr 24, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants