Skip to content

[release-1.21] Update grpc-go to 1.79.3#9010

Merged
knative-prow[bot] merged 3 commits intoknative:release-1.21from
kwassell-ibm:04_02_vulnerability_updates
Apr 6, 2026
Merged

[release-1.21] Update grpc-go to 1.79.3#9010
knative-prow[bot] merged 3 commits intoknative:release-1.21from
kwassell-ibm:04_02_vulnerability_updates

Conversation

@kwassell-ibm
Copy link
Copy Markdown

Updates google.golang.org/grpc to 1.79.3 to resolve GHSA-p77j-4mvh-x3m3.

Includes updates from running ./hack/update-deps.sh after making the change.

Proposed Changes

  • Update dependency

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

@knative-prow knative-prow bot requested review from creydr and pierDipi April 2, 2026 17:56
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 2, 2026

Welcome @kwassell-ibm! It looks like this is your first PR to knative/eventing 🎉

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 2, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 2, 2026

Hi @kwassell-ibm. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Apr 2, 2026

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 2, 2026
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why this file changed?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was automatically updated by

$ ./hack/update-deps.sh
Updating Cert Manager to version v1.16.3
Updating Trust Manager to version v0.12.0
"jetstack" has been added to your repositories
=== Update Deps for Golang module: knative.dev/eventing
--- Go mod tidy
...

I have no strong attachment to the change, happy to remove it if you don't want it going in.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine cc @creydr on why it's not deterministic

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference, I had to remove this change to get the unit tests to pass. Before I did, they kept failing with message "Please run hack/update-codegen.sh". Running locally continues to give me the file in the format the unit tests don't like.

@kwassell-ibm
Copy link
Copy Markdown
Author

Needs changes from #9012 to go in first

@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Apr 2, 2026

/retest

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.12%. Comparing base (b612236) to head (d403b0e).
⚠️ Report is 1 commits behind head on release-1.21.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.21    #9010   +/-   ##
=============================================
  Coverage         51.12%   51.12%           
=============================================
  Files               409      409           
  Lines             21368    21368           
=============================================
  Hits              10925    10925           
  Misses             9592     9592           
  Partials            851      851           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kwassell-ibm kwassell-ibm force-pushed the 04_02_vulnerability_updates branch from fc36dee to d5a5155 Compare April 3, 2026 16:36
@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Apr 6, 2026

/assign @creydr @Cali0707 @matzew

@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Apr 6, 2026

/override "codecov/project"
/lgtm
/approve

@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 6, 2026

@dprotaso: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • codecov/project

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • Update codegen
  • build-tests_eventing_release-1.21
  • conformance-tests_eventing_release-1.21
  • reconciler-tests_eventing_release-1.21
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide
  • unit-tests_eventing_release-1.21
  • upgrade-tests_eventing_release-1.21

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override "codecov/project"
/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, kwassell-ibm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2026
@knative-prow knative-prow bot merged commit c9f4c44 into knative:release-1.21 Apr 6, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants