hack: quote dirname substitution and REPO_ROOT_DIR in release.sh

[Ankitsinghsisodya]

Fixes #8991

Summary

• Quote $(dirname "$0") to handle script paths with spaces
• Quote ${REPO_ROOT_DIR} in the cp destination to prevent word-splitting

Unquoted command substitutions and variable expansions break when paths contain whitespace.

[knative-prow]

Hi @Ankitsinghsisodya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Copilot]

Pull request overview

This PR hardens hack/release.sh against paths containing whitespace by ensuring the script invocation and copy destination don’t undergo unintended word-splitting, addressing issue #8991.

Changes:

• Quote the dirname command substitution used to locate and run generate-yamls.sh.
• Quote ${REPO_ROOT_DIR} in the cp destination so repo paths with spaces work correctly.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Ankitsinghsisodya]

@creydr

[Ankitsinghsisodya]

@evankanderson

[creydr]

Thanks for the cleanup @Ankitsinghsisodya
I just saw one more in the code segment

[creydr]

@Ankitsinghsisodya I see a lot of the "quote XYZ in ABC.sh". Can you combine those PRs into one?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.04%. Comparing base (c6be563) to head (b79483b).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8992      +/-   ##
==========================================
+ Coverage   51.02%   51.04%   +0.02%     
==========================================
  Files         409      409              
  Lines       22001    21990      -11     
==========================================
  Hits        11225    11225              
+ Misses       9914     9903      -11     
  Partials      862      862              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ankitsinghsisodya
Once this PR has been reviewed and has the lgtm label, please ask for approval from creydr. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• hack/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Ankitsinghsisodya]

Superseded by #9018, which combines this with #8990 and #9004 into a single PR as requested by @creydr.