-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] RequestReply: Create InitContainer #8518
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chaliuu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @chaliuu! It looks like this is your first PR to knative/eventing 🎉 |
Hi @chaliuu. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes #8320
Since the RequestReply resource needs a trigger to every pod, rather than to the deployment as a whole, we need to create an InitContainer which creates the trigger to the current pod.
Proposed Changes
🎁 created init container scripts to initialize pods with trigger to themselves.
NOTE : NOT TESTED. Blocked by Create Data Plane ticket RequestReply: Create Data Plane #8319
Pre-review Checklist
Release Note
Docs