Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conversion webhook config in EventPolicy CRD #8379

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

creydr
Copy link
Member

@creydr creydr commented Dec 11, 2024

As we don't have multiple EP versions yet, we don't need the conversion webhook configuration in the EventPolicy CRD

/cherry-pick release-v1.16
/cherry-pick release-v1.15

As we don't have multiple EP versions yet, we don't need the conversion webhook configuration in the EventPolicy CRD
@creydr creydr requested a review from pierDipi December 11, 2024 08:12
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 11, 2024
@knative-prow knative-prow bot requested review from Cali0707 and matzew December 11, 2024 08:12
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.25%. Comparing base (bff7b03) to head (b674de7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8379      +/-   ##
==========================================
+ Coverage   64.16%   64.25%   +0.09%     
==========================================
  Files         388      388              
  Lines       23329    23313      -16     
==========================================
+ Hits        14969    14980      +11     
+ Misses       7565     7539      -26     
+ Partials      795      794       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
Copy link

knative-prow bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit f82811b into knative:main Dec 11, 2024
31 of 32 checks passed
@knative-prow-robot
Copy link
Contributor

@creydr: cannot checkout release-v1.16: error checking out "release-v1.16": exit status 1 error: pathspec 'release-v1.16' did not match any file(s) known to git

In response to this:

As we don't have multiple EP versions yet, we don't need the conversion webhook configuration in the EventPolicy CRD

/cherry-pick release-v1.16
/cherry-pick release-v1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot
Copy link
Contributor

@creydr: cannot checkout release-v1.15: error checking out "release-v1.15": exit status 1 error: pathspec 'release-v1.15' did not match any file(s) known to git

In response to this:

As we don't have multiple EP versions yet, we don't need the conversion webhook configuration in the EventPolicy CRD

/cherry-pick release-v1.16
/cherry-pick release-v1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@creydr
Copy link
Member Author

creydr commented Dec 11, 2024

/cherry-pick release-1.15
/cherry-pick release-1.16

@knative-prow-robot
Copy link
Contributor

@creydr: new pull request created: #8380

In response to this:

/cherry-pick release-1.15
/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot
Copy link
Contributor

@creydr: new pull request created: #8381

In response to this:

/cherry-pick release-1.15
/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants