-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List applying policies in InMemoryChannels status #8011
List applying policies in InMemoryChannels status #8011
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8011 +/- ##
==========================================
+ Coverage 67.74% 67.79% +0.04%
==========================================
Files 362 363 +1
Lines 16714 16899 +185
==========================================
+ Hits 11323 11456 +133
- Misses 4695 4735 +40
- Partials 696 708 +12 ☔ View full report in Codecov by Sentry. |
…tPoliciesNotReady)
882beee
to
039a5b9
Compare
039a5b9
to
999f4fc
Compare
pkg/reconciler/inmemorychannel/controller/inmemorychannel_test.go
Outdated
Show resolved
Hide resolved
pkg/reconciler/inmemorychannel/controller/inmemorychannel_test.go
Outdated
Show resolved
Hide resolved
86885c3
to
a1e0b72
Compare
/hold cancel |
/test reconciler-tests |
/lgtm |
Fixes #7977
Proposed Changes
EventPolicies
in the InMemoryChannels.status.policies
, which apply for itEventPoliciesReady
condition to indicate, if the referenced policies are ReadyRelease Note
/hold
until we have #7973, as otherwise the IMCs would not become ready (as the EP stays NotReady)