Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Parallels updates subscription where possible, instead of recrea… #7965

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

7h3-3mp7y-m4n
Copy link
Contributor

Fixes #7961

Proposed Changes

  • 🐛 Fix the Parallels updates subscription

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 5, 2024
Copy link

knative-prow bot commented Jun 5, 2024

Welcome @7h3-3mp7y-m4n! It looks like this is your first PR to knative/eventing 🎉

Copy link

knative-prow bot commented Jun 5, 2024

Hi @7h3-3mp7y-m4n. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 5, 2024
Comment on lines 25 to 26

//"k8s.io/apimachinery/pkg/api/equality"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't need the import, we can just remove it

Suggested change
//"k8s.io/apimachinery/pkg/api/equality"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, I'll also try to deal with the test coverage , thanks @pierDipi

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.73%. Comparing base (3ee2400) to head (1ee3b82).
Report is 5 commits behind head on main.

Current head 1ee3b82 differs from pull request most recent head 5553cf3

Please upload reports for the commit 5553cf3 to get more accurate results.

Files Patch % Lines
pkg/reconciler/parallel/parallel.go 42.85% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7965      +/-   ##
==========================================
- Coverage   69.30%   67.73%   -1.57%     
==========================================
  Files         345      354       +9     
  Lines       16113    16511     +398     
==========================================
+ Hits        11167    11184      +17     
- Misses       4257     4639     +382     
+ Partials      689      688       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member

pierDipi commented Jun 6, 2024

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 6, 2024
@pierDipi pierDipi requested a review from Cali0707 June 6, 2024 15:15
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @7h3-3mp7y-m4n !

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2024
Copy link

knative-prow bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 7h3-3mp7y-m4n, Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2024
@knative-prow knative-prow bot merged commit 8c4cd2e into knative:main Jun 10, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only recreate subscriptions in Parallels when necessary
3 participants