-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Parallels updates subscription where possible, instead of recrea… #7965
Conversation
Welcome @7h3-3mp7y-m4n! It looks like this is your first PR to knative/eventing 🎉 |
Hi @7h3-3mp7y-m4n. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
pkg/reconciler/parallel/parallel.go
Outdated
|
||
//"k8s.io/apimachinery/pkg/api/equality" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't need the import, we can just remove it
//"k8s.io/apimachinery/pkg/api/equality" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, I'll also try to deal with the test coverage , thanks @pierDipi
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7965 +/- ##
==========================================
- Coverage 69.30% 67.73% -1.57%
==========================================
Files 345 354 +9
Lines 16113 16511 +398
==========================================
+ Hits 11167 11184 +17
- Misses 4257 4639 +382
+ Partials 689 688 -1 ☔ View full report in Codecov by Sentry. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks @7h3-3mp7y-m4n !
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 7h3-3mp7y-m4n, Cali0707 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #7961
Proposed Changes
Pre-review Checklist