Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default value for scale cache config values #7666

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Set default value for scale cache config values #7666

merged 2 commits into from
Feb 9, 2024

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Feb 9, 2024

As per title

@pierDipi
Set default value for scale cache values
32a4571 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2024
@pierDipi pierDipi requested review from Cali0707 and removed request for lberk and lionelvillard February 9, 2024 12:25
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 9, 2024
@pierDipi pierDipi changed the title Set default value for scale cache values Set default value for scale cache config values Feb 9, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 9, 2024 •
edited
Loading

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (bcb6100) 74.01% compared to head (905b51a) 73.98%.

Files Patch % Lines
pkg/scheduler/scheduler.go 0.00% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7666      +/-   ##
==========================================
- Coverage   74.01%   73.98%   -0.03%     
==========================================
  Files         262      262              
  Lines       15172    15178       +6     
==========================================
  Hits        11229    11229              
- Misses       3337     3343       +6     
  Partials      606      606

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cali0707
Cali0707 reviewed Feb 9, 2024
View reviewed changes
pkg/scheduler/scheduler.go
Comment on lines +138 to +139
}
return n
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this return a ScaleCacheConfig without the refresh period set if c.RefreshPeriod != 0?

I think we should add a else return c or something similar

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

pierDipi
pierDipi commented Feb 9, 2024
View reviewed changes
pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
Cali0707
Cali0707 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 6f2eaed into knative:main Feb 9, 2024
36 of 39 checks passed
@pierDipi pierDipi deleted the set-defaults-scale-cache branch February 12, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

Assignees

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierDipi @Cali0707