No reason for API ServerSource adapter to not inject istio sidecar #6789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
approved
|
/test unit-tests |
The reasoning as per the comment was that you cannot have istio sidecar when it needs to talk with the API Server but that is not true, pods can talk to the API Server even with istio sidecar injected. For example, I'm injecting a sidecar in eventing-istio for PingSource adapter or Kafka controller and they both work fine. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
inject-istio-sidecar-in-api-server-source
branch
from
2525e61 to
10924c7
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #6789 +/- ##
=======================================
Coverage 80.44% 80.44%
=======================================
Files 236 236
Lines 12206 12206
=======================================
Hits 9819 9819
Misses 1896 1896
Partials 491 491
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
matzew
reviewed
Mar 3, 2023
| @@ -77,7 +77,7 @@ func MakeReceiveAdapter(args *ReceiveAdapterArgs) (*appsv1.Deployment, error) { | |||
| Template: corev1.PodTemplateSpec{ | |||
| ObjectMeta: metav1.ObjectMeta{ | |||
| Annotations: map[string]string{ | |||
| "sidecar.istio.io/inject": "false", // needs to talk to the api server. | |||
There was a problem hiding this comment.
I was actually wonder if remove this 😅
|
/test upgrade-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vishal-chdhry
pushed a commit
to vishal-chdhry/eventing
that referenced
this pull request
Mar 14, 2023
…native#6789) The reasoning as per the comment was that you cannot have istio sidecar when it needs to talk with the API Server but that is not true, pods can talk to the API Server even with istio sidecar injected. For example, I'm injecting a sidecar in eventing-istio for PingSource adapter or Kafka controller and they both work fine. Part of knative#6596 <!-- Please include the 'why' behind your changes if no issue exists --> ## Proposed Changes <!-- Please categorize your changes: - 🎁 Add new feature - 🐛 Fix bug - 🧹 Update or clean up current behavior - 🗑️ Remove feature or internal logic --> - Set sidecar.istio.io/inject to true for API Server Source adapters ### Pre-review Checklist <!-- If these boxes are not checked, you will be asked to complete these requirements or explain why they do not apply to your PR. --> - [ ] **At least 80% unit test coverage** - [ ] **E2E tests** for any new behavior - [ ] **Docs PR** for any user-facing impact - [ ] **Spec PR** for any new API feature - [ ] **Conformance test** for any change to the spec **Release Note** <!-- 📄 If this change has user-visible impact, write a release note in the block below. Include the string "action required" if additional action is required of users switching to the new release, for example in case of a breaking change. Write as if you are speaking to users, not other Knative contributors. If this change has no user-visible impact, no release note is needed. --> ```release-note Set sidecar.istio.io/inject to true for API Server Source adapter pods. ``` Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reasoning as per the comment was that you cannot have istio
sidecar when it needs to talk with the API Server but that is not
true, pods can talk to the API Server even with istio sidecar
injected.
For example, I'm injecting a sidecar in eventing-istio for
PingSource adapter or Kafka controller and they both work
fine.
Part of #6596
Proposed Changes
Pre-review Checklist
Release Note