Fix Channel Data plane spec #3361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added knativehistory thing Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
knative-prow-robot
added
the
size/M
knative-prow-robot
added
the
approved
lberk
reviewed
Jun 22, 2020
docs/spec/channel.md
Outdated
| The Channel SHOULD sample and write traces to the location specified in | ||
| The Channel MUST recognize and pass through all tracing information from sender | ||
| to subscribers using [W3C Tracecontext](https://w3c.github.io/trace-context/), | ||
| although internally It MAY use another mechanism(s) to propagate the tracing |
There was a problem hiding this comment.
... internally It MAY ...
lower case 'i' in it
matzew
approved these changes
Jun 23, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lberk
pushed a commit
to lberk/eventing
that referenced
this pull request
Jun 26, 2020
* Removed DTE spec Added knativehistory thing Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * nit Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
knativehistoryextensionSigned-off-by: Francesco Guardiani francescoguard@gmail.com