Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallel/sequence v1beta reconcilers #3075

Merged
merged 10 commits into from
May 4, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented May 1, 2020

Fixes #

Proposed Changes

  • Use v1beta1 api to reconcile parallel/sequence
  • Run sequence e2e tests with all the channel types. Previously was only using IMC v1beta1.
  • Run parallel e2e tests with all the channel types. Previously was only using IMC v1beta1.

Release Note

- 🧽 Update or clean up current behavior

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 1, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 1, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label May 2, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/flows/v1beta1/sequence_lifecycle.go 2.3% 95.3% 93.0
pkg/reconciler/parallel/parallel.go 69.2% 69.4% 0.2
pkg/reconciler/sequence/sequence.go 70.6% 71.9% 1.3

@lionelvillard
Copy link
Member

works for me.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2020
@knative-prow-robot knative-prow-robot merged commit 3650fd6 into knative:master May 4, 2020
@vaikas vaikas deleted the v1beta-reconcile-flows branch May 4, 2020 15:03
@nachocano nachocano mentioned this pull request Jul 8, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants