Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Traceparent Extension Handling #2873

Merged
merged 7 commits into from
Apr 1, 2020
Merged

Remove Traceparent Extension Handling #2873

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e4ba956
Remove reference to B3 and OpenTracing in channel doc
ian-mi Mar 31, 2020
6705902
Replace B3 and OpenTracing headers with Traceparent header in tests
ian-mi Mar 31, 2020
2fb3bee
Use the DistributedTracingExtension type in traceparent_transformer
ian-mi Mar 30, 2020
0f7e221
Remove traceparent handling from pkg/tracing
ian-mi Mar 30, 2020
cfc6f2c
Remove OpenCensus SetSpanID patch
ian-mi Mar 30, 2020
c8b9c10
Remove deprecated NewDefaultClientGivenHttpTransport function.
ian-mi Mar 30, 2020
7c21919
Merge remote-tracking branch 'origin/master' into remove-traceparent-…
ian-mi Mar 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove OpenCensus SetSpanID patch
  • Loading branch information
@ian-mi
ian-mi committed Mar 31, 2020
commit cfc6f2c51e56a672b7ccf8be2416ace46d6618af
18 changes: 0 additions & 18 deletions hack/set-span-id.patch
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions hack/update-deps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,3 @@ rm -rf $(find vendor/ -name 'BUILD.bazel')

update_licenses third_party/VENDOR-LICENSE \
$(find . -name "*.go" | grep -v vendor | xargs grep "package main" | cut -d: -f1 | xargs -n1 dirname | uniq)

# HACK HACK HACK
# The only way we found to create a consistent Trace tree without any missing Spans is to
# artificially set the SpanId. See pkg/tracing/traceparent.go for more details.
# Produced with:
# git diff origin/master HEAD -- vendor/go.opencensus.io/trace/trace.go > ./hack/set-span-id.patch
git apply ${REPO_ROOT_DIR}/hack/set-span-id.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! thanks @ian-mi 🎉

7 changes: 0 additions & 7 deletions vendor/go.opencensus.io/trace/trace.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.