Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For now, disable --strict mode for release #2747

Merged
merged 1 commit into from
Mar 10, 2020
Merged

For now, disable --strict mode for release #2747

merged 1 commit into from
Mar 10, 2020

Conversation

chizhg
Copy link
Member

@chizhg chizhg commented Mar 10, 2020

Proposed Changes

  • For now, disable --strict mode for release

/cc @grantr

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 10, 2020
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release labels Mar 10, 2020
grantr
grantr approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/cc @mattmoor

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chizhg, grantr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grantr
Copy link
Contributor

grantr commented Mar 10, 2020

See #2745 and #2746 (comment) for context.

mattmoor
mattmoor reviewed Mar 10, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

🎉 thanks

@knative-prow-robot knative-prow-robot merged commit a90af00 into knative:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@grantr grantr grantr approved these changes

Assignees

@grantr grantr

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chizhg @knative-prow-robot @grantr @mattmoor @googlebot