-
Notifications
You must be signed in to change notification settings - Fork 597
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Pull in the new fancier webhook drain from knative/pkg. (#3634)
This is attempting to try and combat the webhook Post EOF errors we have been seeing intermittently: knative/pkg#1509
- Loading branch information
Showing
13 changed files
with
423 additions
and
66 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,159 @@ | ||
| /* | ||
| Copyright 2020 The Knative Authors | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package controller | ||
|
|
||
| import ( | ||
| "k8s.io/client-go/util/workqueue" | ||
| ) | ||
|
|
||
| // twoLaneQueue is a rate limited queue that wraps around two queues | ||
| // -- fast queue (anonymously aliased), whose contents are processed with priority. | ||
| // -- slow queue (slowLane queue), whose contents are processed if fast queue has no items. | ||
| // All the default methods operate on the fast queue, unless noted otherwise. | ||
| type twoLaneQueue struct { | ||
| workqueue.RateLimitingInterface | ||
| slowLane workqueue.RateLimitingInterface | ||
| // consumerQueue is necessary to ensure that we're not reconciling | ||
| // the same object at the exact same time (e.g. if it had been enqueued | ||
| // in both fast and slow and is the only object there). | ||
| consumerQueue workqueue.Interface | ||
|
|
||
| name string | ||
|
|
||
| fastChan chan interface{} | ||
| slowChan chan interface{} | ||
| } | ||
|
|
||
| // Creates a new twoLaneQueue. | ||
| func newTwoLaneWorkQueue(name string) *twoLaneQueue { | ||
| rl := workqueue.DefaultControllerRateLimiter() | ||
| tlq := &twoLaneQueue{ | ||
| RateLimitingInterface: workqueue.NewNamedRateLimitingQueue( | ||
| rl, | ||
| name+"-fast", | ||
| ), | ||
| slowLane: workqueue.NewNamedRateLimitingQueue( | ||
| rl, | ||
| name+"-slow", | ||
| ), | ||
| consumerQueue: workqueue.NewNamed(name + "-consumer"), | ||
| name: name, | ||
| fastChan: make(chan interface{}), | ||
| slowChan: make(chan interface{}), | ||
| } | ||
| // Run consumer thread. | ||
| go tlq.runConsumer() | ||
| // Run producer threads. | ||
| go process(tlq.RateLimitingInterface, tlq.fastChan) | ||
| go process(tlq.slowLane, tlq.slowChan) | ||
| return tlq | ||
| } | ||
|
|
||
| func process(q workqueue.Interface, ch chan interface{}) { | ||
| // Sender closes the channel | ||
| defer close(ch) | ||
| for { | ||
| i, d := q.Get() | ||
| // If the queue is empty and we're shutting down — stop the loop. | ||
| if d { | ||
| break | ||
| } | ||
| ch <- i | ||
| q.Done(i) | ||
| } | ||
| } | ||
|
|
||
| func (tlq *twoLaneQueue) runConsumer() { | ||
| // Shutdown flags. | ||
| fast, slow := true, true | ||
| // When both producer queues are shutdown stop the consumerQueue. | ||
| defer tlq.consumerQueue.ShutDown() | ||
| // While any of the queues is still running, try to read off of them. | ||
| for fast || slow { | ||
| // By default drain the fast lane. | ||
| // Channels in select are picked random, so first | ||
| // we have a select that only looks at the fast lane queue. | ||
| if fast { | ||
| select { | ||
| case item, ok := <-tlq.fastChan: | ||
| if !ok { | ||
| // This queue is shutdown and drained. Stop looking at it. | ||
| fast = false | ||
| continue | ||
| } | ||
| tlq.consumerQueue.Add(item) | ||
| continue | ||
| default: | ||
| // This immediately exits the wait if the fast chan is empty. | ||
| } | ||
| } | ||
|
|
||
| // If the fast lane queue had no items, we can select from both. | ||
| // Obviously if suddenly both are populated at the same time there's a | ||
| // 50% chance that the slow would be picked first, but this should be | ||
| // a rare occasion not to really worry about it. | ||
| select { | ||
| case item, ok := <-tlq.fastChan: | ||
| if !ok { | ||
| // This queue is shutdown and drained. Stop looking at it. | ||
| fast = false | ||
| continue | ||
| } | ||
| tlq.consumerQueue.Add(item) | ||
| case item, ok := <-tlq.slowChan: | ||
| if !ok { | ||
| // This queue is shutdown and drained. Stop looking at it. | ||
| slow = false | ||
| continue | ||
| } | ||
| tlq.consumerQueue.Add(item) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Shutdown implements workqueue.Interace. | ||
| // Shutdown shuts down both queues. | ||
| func (tlq *twoLaneQueue) ShutDown() { | ||
| tlq.RateLimitingInterface.ShutDown() | ||
| tlq.slowLane.ShutDown() | ||
| } | ||
|
|
||
| // Done implements workqueue.Interface. | ||
| // Done marks the item as completed in all the queues. | ||
| // NB: this will just re-enqueue the object on the queue that | ||
| // didn't originate the object. | ||
| func (tlq *twoLaneQueue) Done(i interface{}) { | ||
| tlq.consumerQueue.Done(i) | ||
| } | ||
|
|
||
| // Get implements workqueue.Interface. | ||
| // It gets the item from fast lane if it has anything, alternatively | ||
| // the slow lane. | ||
| func (tlq *twoLaneQueue) Get() (interface{}, bool) { | ||
| return tlq.consumerQueue.Get() | ||
| } | ||
|
|
||
| // Len returns the sum of lengths. | ||
| // NB: actual _number_ of unique object might be less than this sum. | ||
| func (tlq *twoLaneQueue) Len() int { | ||
| return tlq.RateLimitingInterface.Len() + tlq.slowLane.Len() + tlq.consumerQueue.Len() | ||
| } | ||
|
|
||
| // SlowLane gives direct access to the slow queue. | ||
| func (tlq *twoLaneQueue) SlowLane() workqueue.RateLimitingInterface { | ||
| return tlq.slowLane | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.