-
Notifications
You must be signed in to change notification settings - Fork 225
Kafka source tracing #1211
Kafka source tracing #1211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold Something is wrong in the message writer, i don't see the traceparent extension written down the wire |
There is a bug in sdk-go that prevents this to be merged: cloudevents/sdk-go#499 As soon as we update sdk-go, this one is ready |
Let's also try to bring this one in knative/eventing#3101, so we can remove some duplicated code |
6e7c00f
to
f856300
Compare
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
f856300
to
f71f616
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
/unhold |
/retest |
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
The following is the coverage report on the affected files.
|
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@slinkydeveloper: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Francesco Guardiani francescoguard@gmail.com
Fixes #1195
Proposed Changes
knative-tracing
config map. Default is no-op