Fix KafkaSource conversion (#1650)

knative · Oct 27, 2020 · 10d7a7f · 10d7a7f
1 parent ff520a0
commit 10d7a7f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/kafka/source/pkg/apis/sources/v1alpha1/kafka_conversion.go b/kafka/source/pkg/apis/sources/v1alpha1/kafka_conversion.go
@@ -44,8 +44,7 @@ func (source *KafkaSource) ConvertTo(ctx context.Context, obj apis.Convertible)
 			Topics:        source.Spec.Topics,
 			ConsumerGroup: source.Spec.ConsumerGroup,
 		}
-		sink.Status.Status = source.Status.Status
-		source.Status.Status.ConvertTo(ctx, &sink.Status.Status)
+		source.Status.Status.DeepCopyInto(&sink.Status.Status)
 		// Optionals
 		if source.Spec.Sink != nil {
 			sink.Spec.Sink = *source.Spec.Sink.DeepCopy()
@@ -83,8 +82,7 @@ func (sink *KafkaSource) ConvertFrom(ctx context.Context, obj apis.Convertible)
 		if reflect.DeepEqual(*sink.Spec.Sink, duckv1.Destination{}) {
 			sink.Spec.Sink = nil
 		}
-		sink.Status.Status = source.Status.Status
-		source.Status.Status.ConvertTo(ctx, &source.Status.Status)
+		source.Status.Status.DeepCopyInto(&sink.Status.Status)
 		// Optionals
 		if source.Status.SinkURI != nil {
 			sink.Status.SinkURI = source.Status.SinkURI.DeepCopy()

diff --git a/kafka/source/pkg/apis/sources/v1alpha1/kafka_conversion_test.go b/kafka/source/pkg/apis/sources/v1alpha1/kafka_conversion_test.go
@@ -163,6 +163,9 @@ func TestKafkaSourceConversionRoundTripV1alpha1(t *testing.T) {
 						Conditions: duckv1.Conditions{{
 							Type:   "Ready",
 							Status: "True",
+						}, {
+							Type:   "SinkProvided",
+							Status: "True",
 						}},
 						Annotations: map[string]string{
 							"foo": "bar",
@@ -327,6 +330,9 @@ func TestKafkaSourceConversionRoundTripV1beta1(t *testing.T) {
 						Conditions: duckv1.Conditions{{
 							Type:   "Ready",
 							Status: "True",
+						}, {
+							Type:   "SinkProvided",
+							Status: "True",
 						}},
 						Annotations: map[string]string{
 							"foo": "bar",