Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document installation and usage of logging, monitoring and tracing components #92

Merged
merged 2 commits into from
Jul 10, 2018
Merged

Document installation and usage of logging, monitoring and tracing components #92

merged 2 commits into from
Jul 10, 2018

Conversation

mdemirhan
Copy link
Contributor

Document installation and usage of logging, monitoring and tracing components

@google-prow-robot google-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 10, 2018
Copy link
Member

@mchmarny mchmarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2018
@mchmarny
Copy link
Member

/approve

@google-prow-robot google-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2018
@mchmarny
Copy link
Member

/approve

@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mchmarny, mdemirhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mchmarny
Copy link
Member

/lgtm

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2018
@mdemirhan mdemirhan merged commit 2e8418c into knative:master Jul 10, 2018
@mdemirhan mdemirhan deleted the debuggingdocs branch July 10, 2018 21:09
@nrshrivatsan
Copy link

nrshrivatsan commented Sep 9, 2018

Excellent work @mdemirhan. Perfect example of how the Monitoring of Kubernetes itself has to be - for autoscaling!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants