Updates to GKE and Minikube install guides #79
Conversation
google-prow-robot
added
the
size/L
|
/retest |
|
|
||
| We are using the `https://storage.googleapis.com/knative-releases/latest/release-lite.yaml` file which omits some of the monitoring components to reduce the memory used by the Knative components since you do have limited resources available. To use the provided `release-lite.yaml` release run: | ||
| We are using the `https://storage.googleapis.com/knative-releases/latest/release-lite.yaml` |
There was a problem hiding this comment.
Same replacement of LoadBalancer to NodePort as for istio.yaml is needed to be done for release-lite.yaml.
If release-lite.yaml is meant for Minikube only, then maybe that should be done in release.sh.
There was a problem hiding this comment.
Have you opened an issue on this in the serving repo?
There was a problem hiding this comment.
Yes, for updating docs knative/serving#1484
@krancour also opened related #72 which is fixed by this PR
There was a problem hiding this comment.
I see -- it's actually a documentation bug, because you need to update something in istio.yaml, not that we need to change the release.sh script. Got it! I'll
|
|
||
| We are using the `https://storage.googleapis.com/knative-releases/latest/release-lite.yaml` file which omits some of the monitoring components to reduce the memory used by the Knative components since you do have limited resources available. To use the provided `release-lite.yaml` release run: | ||
| We are using the `https://storage.googleapis.com/knative-releases/latest/release-lite.yaml` |
There was a problem hiding this comment.
Have you opened an issue on this in the serving repo?
| @@ -81,17 +95,22 @@ CTRL+C when it's done. | |||
|
|
|||
| Now you can deploy your app/function to your newly created Knative cluster. | |||
|
|
|||
| ## Test App | |||
| ## Deploying an app | |||
There was a problem hiding this comment.
We should point to the hello-world samples here, like we do in the GKE walkthrough.
There was a problem hiding this comment.
I'll be working on another PR that makes updates to the "Deploying an app" section; I was going to address the mismatch between the two at that point.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rgregg, samodell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proposed Changes