Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the golang redirect for autoscaler-keda and func-python #5970

Merged
merged 1 commit into from
May 14, 2024
Merged

Added the golang redirect for autoscaler-keda and func-python #5970

merged 1 commit into from
May 14, 2024

Conversation

skonto
Copy link
Contributor

@skonto skonto commented May 14, 2024 •
edited
Loading

"Fixes #issue-number" or "Add description of the problem this PR solves"

Proposed Changes

  • Similar to Added the golang redirect for serving-progressive-rollout #5691
  • Needed for New Repo: autoscaler-keda community#1527
  • I run the tool for generating redirects but I hit a rate limit with anonymous github API requests (50). I upgraded the github client locally, in order to pass a token to bypass the rate limit. Client is very old btw. If we want to upgrade that part we will need a re-write of the paging part, because it didnt work and I had to increase the items return from 50 to 100: ListOptions: github.ListOptions{PerPage: 100},. The actual problem is that

if resp.NextPage == 0 {
break }

never gets updated and never reaches 0.

@knative-prow knative-prow bot requested review from csantanapr and snneji May 14, 2024 14:35
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 14, 2024
@netlify Netlify
Copy link

netlify bot commented May 14, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 72b9f25
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/664376cb2f022a00085dc397
😎 Deploy Preview https://deploy-preview-5970--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@skonto skonto requested a review from dprotaso May 14, 2024 14:36
dprotaso
dprotaso reviewed May 14, 2024
View reviewed changes
golang/_redirects
@@ -49,7 +48,6 @@
/kn-plugin-source-kamelet/* go-get=:go-get /golang/kn-plugin-source-kamelet.html 200
/knobots/* go-get=:go-get /golang/knobots.html 200
/monitoring/* go-get=:go-get /golang/monitoring.html 200
/net-certmanager/* go-get=:go-get /golang/net-certmanager.html 200
Copy link
Member

@dprotaso dprotaso May 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shouldn't drop some of these old redirects - since it will break older release branches etc.

I wonder if we should disable deleting entries for archived repos

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I can fix it in another PR.

@matzew
Copy link
Member

matzew commented May 14, 2024

and for func-python, not just KEDA

matzew
matzew approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

skonto
skonto commented May 14, 2024
View reviewed changes
golang/func-python.html
@@ -0,0 +1,4 @@
<html><head>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tool discovered the func-python repo as well.

@skonto skonto changed the title Added the golang redirect for autoscaler-keda Added the golang redirect for autoscaler-keda and func-python May 14, 2024
@knative-prow knative-prow bot merged commit 7a7e30c into knative:main May 14, 2024
19 checks passed
@skonto skonto mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso dprotaso left review comments

@matzew matzew matzew approved these changes

@csantanapr csantanapr Awaiting requested review from csantanapr

@snneji snneji Awaiting requested review from snneji

Assignees

@dprotaso dprotaso

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skonto @matzew @dprotaso