Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a little blog, explaining the workloads override for HA replicas #5600

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

matzew
Copy link
Member

@matzew matzew commented Jun 13, 2023

Proposed Changes

  • new blog post on workloads override, with the focus for HA config

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bad9b53
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/648838093313ba0008e54dd5
😎 Deploy Preview https://deploy-preview-5600--knative.netlify.app/blog/articles/improved-ha-configuration
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 13, 2023
@matzew
Copy link
Member Author

matzew commented Jun 13, 2023

/assign @pierDipi

@pierDipi
Copy link
Member

/approve

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2023
mt-broker-ingress 3/3 3 3 51s
```

For each workload we do see exactly three deployements. Now, take a detailed look at the above shell snippet. You will notice that for the `InMemoryChannel` we do have `6` deployments: `3` for each, the `controller` and the `dispatcher` data-plane. This is not always what you want, since the `InMemoryChannel` is more often used as a tool during development, while in production scenarios other worksloads, like the K[native Broker](https://knative.dev/docs/eventing/brokers/broker-types/kafka-broker/) or [Knative Channel](https://knative.dev/docs/eventing/configuration/kafka-channel-configuration/) implementations for Apache Kafka are being used.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K[native Broker] > [Knative Broker]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slower than @pierDipi :)

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@matzew
Copy link
Member Author

matzew commented Jun 13, 2023

@ReToCode @pierDipi thanks for the review, I've updated that

@matzew
Copy link
Member Author

matzew commented Jun 13, 2023

/assign @psschwei

Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2023
@knative-prow
Copy link

knative-prow bot commented Jun 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 5b8c656 into knative:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants