Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve blue/green demo doc #226

Merged
merged 1 commit into from
Jul 20, 2018
Merged

improve blue/green demo doc #226

merged 1 commit into from
Jul 20, 2018

Conversation

krancour
Copy link
Contributor

@krancour krancour commented Jul 20, 2018

Fixes #196

This updates the blue/green deployment demo to show edits to an existing configuration to produce a new revision, then routing based on revision name instead of configuration name.

cc @rgregg @mchmarny

@google-prow-robot google-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 20, 2018
@mchmarny mchmarny self-requested a review July 20, 2018 22:11
@mchmarny
Copy link
Member

/lgtm
/approve

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2018
@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krancour, mchmarny

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mchmarny
Copy link
Member

The instructions work, we can cleanup the verbiage after it lands

@google-prow-robot google-prow-robot merged commit 13a3f1b into knative:master Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants