-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AKS installation walkthrough #210
Conversation
This PR adds a walkthrough providing instructions on how to install knative on Azure Kubernetes Service. It also adds a little more wording to the opening of README.md. Closes: #208
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Oooops, I'l get myself added to the Microsoft CLA. |
I signed it! |
CLAs look good, thanks! |
install/Knative-with-AKS.md
Outdated
``` | ||
1. Create the AKS cluster! | ||
```bash | ||
az aks create --resource-group $RESOURCE_GROUP --name $CLUSTER_NAME --generate-ssh-keys --kubernetes-version 1.10.5 --enable-rbac --node-vm-size Standard_DS3_v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest wrapping this command line, since you have to scroll to read it in the markdown view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make that change and push it up. Thanks! 👍
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeremyrickard, rgregg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #208
Proposed Changes
on Azure Kubernetes Service.
of README.md.