Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AKS installation walkthrough #210

Merged
merged 6 commits into from
Jul 20, 2018
Merged

Add AKS installation walkthrough #210

merged 6 commits into from
Jul 20, 2018

Conversation

jeremyrickard
Copy link
Contributor

Fixes #208

Proposed Changes

  • This PR adds a walkthrough providing instructions on how to install knative
    on Azure Kubernetes Service.
  • It also adds a little more wording to the opening
    of README.md.

This PR adds a walkthrough providing instructions on how to install knative
on Azure Kubernetes Service. It also adds a little more wording to the opening
of README.md.

Closes: #208
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@google-prow-robot google-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 19, 2018
@jeremyrickard
Copy link
Contributor Author

Oooops, I'l get myself added to the Microsoft CLA.

@jeremyrickard
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

```
1. Create the AKS cluster!
```bash
az aks create --resource-group $RESOURCE_GROUP --name $CLUSTER_NAME --generate-ssh-keys --kubernetes-version 1.10.5 --enable-rbac --node-vm-size Standard_DS3_v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest wrapping this command line, since you have to scroll to read it in the markdown view.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make that change and push it up. Thanks! 👍

@rgregg
Copy link
Contributor

rgregg commented Jul 20, 2018

/lgtm

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2018
@google-prow-robot google-prow-robot added approved and removed lgtm Indicates that a PR is ready to be merged. labels Jul 20, 2018
@rgregg
Copy link
Contributor

rgregg commented Jul 20, 2018

/lgtm
/approve

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2018
@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeremyrickard, rgregg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot merged commit bfc05e6 into knative:master Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants