Fixing language in the source to url sample #189
Conversation
google-prow-robot
added
approved
size/L
| * A Kubernetes cluster with Knative installed. Follow the | ||
| [installation instructions](https://github.com/knative/docs/blob/master/install/README.md) if you need | ||
| to create one. | ||
| * Go installed and configured (optional, if you want to run the sample app | ||
| locally). | ||
| * Go installed and configured. This is optional, if you want to run the sample app |
There was a problem hiding this comment.
This is optional, and is only required if ...
| You need to install a [Build Template](https://github.com/knative/build-templates) | ||
| that will be used by the sample, and register a secret for your container | ||
| registry. In this example, we'll use Docker Hub. | ||
| To use this sample, you need to install a build template and register a secret for Docker Hub. |
There was a problem hiding this comment.
Does this need to be Docker Hub, and not e.g. gcr.io?
There was a problem hiding this comment.
@rgregg Ryan, do you know?
There was a problem hiding this comment.
For the samples in general, we've been using Docker Hub because it's agnostic of any of the Knative authors. We got good community feedback that we shouldn't use GCR all the time.
|
|
||
| Now you can apply this manifest using kubectl, and watch the results: | ||
|
|
||
| 1. You need to create a service manifest which defines the service to deploy, including where |
There was a problem hiding this comment.
GitHub isn't rendering the numbers correctly. Each point is 1, so there's probably a whitespace issue here somewhere.
|
|
||
|
|
||
| 1. After the build has completed and the container is pushed to docker hub, you | ||
| 1. Once you see the deployment pod switch to the running state, press Ctrl+C to |
There was a problem hiding this comment.
The numbering restarts here too, for some reason.
| revisionTemplate: | ||
| spec: | ||
| container: | ||
| image: *image |
There was a problem hiding this comment.
I think that we should have a comment explaining this or just duplicate the image name.
There was a problem hiding this comment.
@mattmoor do you mean changing this to:
image: IMAGE
There was a problem hiding this comment.
We should change this to:
- name: IMAGE
value: docker.io/..
spec:
container:
image: docker.io/...
There was a problem hiding this comment.
Basically remove the &image and *image syntax, which is a bit of YAML magic
| @@ -1,48 +1,46 @@ | |||
| # Source to URL - Go | |||
| # Orchestrating a source-to-URL deployement on Kubernetes | |||
|
/retest |
1 similar comment
|
/retest |
| @@ -234,7 +210,7 @@ status: | |||
| ``` | |||
|
|
|||
| 1. Now you can make a request to your app to see the result. Replace | |||
| `{IP_ADDRESS}` with the address you see returned in the previous step. | |||
| `{IP_ADDRESS}` with the address that you got in the previous step: | |||
|
|
|||
| ```shell | |||
| curl -H "Host: app-from-source.default.example.com" http://{IP_ADDRESS} | |||
There was a problem hiding this comment.
Needs the license footer at the bottom of this file.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: labadav, rgregg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #78
Proposed Changes