Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First pass of community guideline updates #168

Merged
merged 3 commits into from
Jul 18, 2018
Merged

First pass of community guideline updates #168

merged 3 commits into from
Jul 18, 2018

Conversation

samodell
Copy link
Contributor

@samodell samodell commented Jul 18, 2018 •
edited by evankanderson
Loading

Remove duplicate code of conduct.

Add reference to documentation style guide.

Rewrap contributing and add some additional supporting detail to answer common questions.

@google-prow-robot google-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 18, 2018
@samodell
Copy link
Contributor Author

/assign @labadav

labadav
labadav approved these changes Jul 18, 2018
View reviewed changes
Copy link
Contributor

@labadav labadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2018
@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: labadav, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot merged commit 3b6b255 into knative:master Jul 18, 2018
@samodell samodell deleted the contribupdates branch July 20, 2018 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labadav labadav labadav approved these changes

@mattmoor mattmoor Awaiting requested review from mattmoor

@RichieEscarez RichieEscarez Awaiting requested review from RichieEscarez

Assignees

@labadav labadav

Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samodell @google-prow-robot @labadav