Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of documentation on queue-proxy probing #5331

Open
mbrancato opened this issue Nov 18, 2022 · 5 comments
Open

Lack of documentation on queue-proxy probing #5331

mbrancato opened this issue Nov 18, 2022 · 5 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@mbrancato
Copy link

Describe the change you'd like to see
Comprehensive documentation on queue-proxy probing controls and behaviors.

Additional context
Readiness probing, and specifically aggressive probing, is part of the queue-proxy sidecar. Some services are slower to start than others, may have backend dependencies such as a database, etc. However, there is really no documentation on how to configure the queue-proxy probing behavior in the documentation.

e.g. As of today there are conflicting notes / comments that seem to describe the same thing about disabling aggressive probing, with opposite instructions in another knative project. One says to set periodSeconds>0 while the other says to set periodSeconds=0 to disable aggressive probing.

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 17, 2023
@mbrancato
Copy link
Author

/reopen

@knative-prow
Copy link

knative-prow bot commented Mar 20, 2023

@mbrancato: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot reopened this Mar 20, 2023
@mbrancato
Copy link
Author

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 20, 2023
@dprotaso
Copy link
Member

/lifecycle frozen

@knative-prow knative-prow bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

2 participants